Just make a note in both PRs that they need to be merged at the same time and link the two
PRs to each other. Someone will get them both.
On Jul 29, 2019, at 9:12 AM, Jeff Barber
Hi Zeek devs,
I found an issue with duplicate packets not getting properly marked as TCP
retransmissions. I generated a PR for it on Friday (https://github.com/zeek/zeek/pull/494
<https://github.com/zeek/zeek/pull/494>), including the necessary changes to make
the built-in test suite pass.
However, the automatic Travis CI process that gets executed for a PR is also downloading
tests from an external repo: https://github.com/zeek/zeek-testing
<https://github.com/zeek/zeek-testing> and those tests are failing -- because the
fix changes the connection history values in all the connections (many traces actually
have duplicate packets in them that were previously not noted in the history string).
The real question here is:
I don't mind updating the zeek-testing repo for the necessary changes, but how would
I coordinate that change? "this zeek PR needs to go with that zeek-testing PR"
zeek-dev mailing list