]
Daniel Thayer commented on BIT-1342:
------------------------------------
This is a race condition caused by daemon threads (sometimes) still running when
broctl terminates.
Occasional test failures
------------------------
Key: BIT-1342
URL:
https://bro-tracker.atlassian.net/browse/BIT-1342
Project: Bro Issue Tracker
Issue Type: Problem
Components: BroControl
Reporter: Robin Sommer
Fix For: 2.4
Two tests in current master fail for me occasionally (usually when I run the full broctl
test-suite but not when I rerun just these failing tests). Diag output below.
{code}
command.start-stop-standalone ... failed
% 'btest-diff stop.out' failed unexpectedly (exit code 1)
% cat .diag
== File ===============================
stopping bro ...
Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
File "/usr/lib64/python2.7/threading.py", line 811, in __bootstrap_inner
File
"/home/robin/bro/master/aux/broctl/testing/../build/testing/test.21123/lib/broctl/BroControl/ssh_runner.py",
line
File
"/home/robin/bro/master/aux/broctl/testing/../build/testing/test.21123/lib/broctl/BroControl/ssh_runner.py",
line
File "/usr/lib64/python2.7/Queue.py", line 177, in get
File "/usr/lib64/python2.7/threading.py", line 354, in wait
<type 'exceptions.TypeError'>: 'NoneType' object is not
callable
== Diff ===============================
---
/home/robin/bro/master/aux/broctl/testing/Baseline/command.start-stop-standalone/stop.out
2013-06-01 00:29:07.0000
+++ stop.out 2015-03-17 22:50:01.857838625 +0000
@@ -1 +1,9 @@
stopping bro ...
+Exception in thread Thread-1 (most likely raised during interpreter shutdown):
+Traceback (most recent call last):
+ File "/usr/lib64/python2.7/threading.py", line 811, in __bootstrap_inner
+ File
"/home/robin/bro/master/aux/broctl/testing/../build/testing/test.21123/lib/broctl/BroControl/ssh_runner.py",
l
+ File
"/home/robin/bro/master/aux/broctl/testing/../build/testing/test.21123/lib/broctl/BroControl/ssh_runner.py",
l
+ File "/usr/lib64/python2.7/Queue.py", line 177, in get
+ File "/usr/lib64/python2.7/threading.py", line 354, in wait
+<type 'exceptions.TypeError'>: 'NoneType' object is not
callable
=======================================
[...]
command.start-cluster-slowstart ... failed
% 'btest-diff status2.out' failed unexpectedly (exit code 1)
% cat .diag
== File ===============================
Getting process status ...
Getting peer status ...
Name Type Host Status Pid Peers Started
manager manager localhost stopped
proxy-1 proxy localhost stopped
worker-1 worker localhost stopped
worker-2 worker localhost stopped
== Diff ===============================
---
/home/robin/bro/master/aux/broctl/testing/Baseline/command.start-cluster-slowstart/status2.out
2015-03-04 20:16
+++ status2.out 2015-03-17 22:50:26.578618684 +0000
@@ -3,5 +3,5 @@
Name Type Host Status Pid Peers Started
manager manager localhost stopped
proxy-1 proxy localhost stopped
-worker-1 worker localhost crashed
+worker-1 worker localhost stopped
worker-2 worker localhost stopped
=======================================
{code}