#474: &raw_output turns null values into \0 ----------------------+--------------------- Reporter: seth | Owner: Type: Problem | Status: new Priority: Normal | Milestone: Bro1.6 Component: Bro | Version: Resolution: | Keywords: preview ----------------------+--------------------- Comment (by jsiwek): In [648e1bda267244dc3f785a9718044b71d73f427b/bro]: {{{ #!CommitTicketReference repository="bro" revision="648e1bda267244dc3f785a9718044b71d73f427b" Fix &raw_output and enable_raw_output interpretation of NUL characters When using a `print` statement to write to a file that has raw output enabled, NUL characters in string are no longer interpreted into "\0", no newline is appended afterwards, and each argument to `print` is written to the file without any additional separation. (Re)Assigning to identifiers with the &raw_output attribute should also now correctly apply the attribute to the file value being assigned. Note that the write_file BiF should already be capable of raw string data to a file, expect it bypasses the print_hook event. Addresses #474 }}} -- Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:2> Bro Tracker <http://tracker.bro-ids.org/bro> Bro Issue Tracker

#474: &raw_output turns null values into \0 ----------------------------+------------------------ Reporter: seth | Owner: Type: Merge Request | Status: new Priority: Normal | Milestone: Bro1.6 Component: Bro | Version: git/master Resolution: | Keywords: preview ----------------------------+------------------------ Comment (by robin): I'm somewhat reluctant to apply this part. Bro is already inconsistent with what happens with attributes on assigment, and I don't want to make it worse. Here, the attribute would now be transfered from the target to the value being assigned, which doesn't sound right (it makes sense in terms of what one wants to achieve, but still…) Can we leave this part out and use the enable_raw_output() function instead? Otherwise, nice patch! -- Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:4> Bro Tracker <http://tracker.bro-ids.org/bro> Bro Issue Tracker

#474: &raw_output turns null values into \0 ----------------------------+------------------------ Reporter: seth | Owner: jsiwek Type: Merge Request | Status: assigned Priority: Normal | Milestone: Bro1.6 Component: Bro | Version: git/master Resolution: | Keywords: preview ----------------------------+------------------------ Comment (by robin): | Can we leave this part out and use the enable_raw_output() function instead? That's just the part in NameExpr, correct? I'll commit without that for now. -- Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:6> Bro Tracker <http://tracker.bro-ids.org/bro> Bro Issue Tracker

#474: &raw_output turns null values into \0 ----------------------+------------------------ Reporter: seth | Owner: jsiwek Type: Problem | Status: assigned Priority: Normal | Milestone: Bro1.6 Component: Bro | Version: git/master Resolution: | Keywords: preview ----------------------+------------------------ Changes (by jsiwek): * type: Merge Request => Problem -- Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:8> Bro Tracker <http://tracker.bro-ids.org/bro> Bro Issue Tracker

#474: &raw_output turns null values into \0 ----------------------+------------------------ Reporter: seth | Owner: jsiwek Type: Problem | Status: assigned Priority: Normal | Milestone: Bro1.7 Component: Bro | Version: git/master Resolution: | Keywords: preview ----------------------+------------------------ Changes (by jsiwek): * milestone: Bro1.6 => Bro1.7 Comment: Replying to [comment:9 seth]: until later since none of the shipped scripts do logs directly with print anymore. Ok. As a reminder for when we figure out what to do with file attributes: the current `language/raw_output_attr` unit test should replace use of the `enable_raw_output` BIF with `&raw_output` and also needs to check application of the attribute to global variables since they get handled slightly differently than locals. (There's already a test for the BIF in `bifs/enable_raw_output`) -- Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:10> Bro Tracker <http://tracker.bro-ids.org/bro> Bro Issue Tracker

#474: &raw_output turns null values into \0 ----------------------+------------------------ Reporter: seth | Owner: jsiwek Type: Problem | Status: assigned Priority: Normal | Milestone: Bro2.2 Component: Bro | Version: git/master Resolution: | Keywords: preview ----------------------+------------------------ Comment (by jsiwek): In [784adf3f6ba781f0ade427d8f7177c540d8f7100/bro]: {{{ #!CommitTicketReference repository="bro" revision="784adf3f6ba781f0ade427d8f7177c540d8f7100" Fixes to attribute propagation issues for variables and types. - A type declarations w/ attributes will propogate them to local and global variable declarations that use the type. Addresses #248. - A local or global variable declared with attributes will propogate them values that are later assigned to it. Addresses #151, #67, #474. Addresses #327 in that it should be a more consistent approach to attribute propagation than before: the rules are that they can migrate in one direction: type -> variable -> value. It also clears up the most common usage issue: the expectation that attributes in a local or global variable declaration apply to the identifier in that declaration such that later values assigned to it are subjected to those attributes. }}} -- Ticket URL: <http://tracker.bro-ids.org/bro/ticket/474#comment:12> Bro Tracker <http://tracker.bro-ids.org/bro> Bro Issue Tracker