2 Nov
2011
2 Nov
'11
1:31 p.m.
#660: Initializing a table with a record as an index does not work
--------------------+---------------------
Reporter: amannb | Type: Problem
Status: new | Priority: Normal
Milestone: | Component: Bro
Version: | Keywords:
--------------------+---------------------
The following code
{{{
type irecord: record {
resp_h: addr;
};
global my_table: table[irecord] of int = {
[[$resp_h=1.2.3.4]] = 12,
};
}}}
results in an error:
{{{
error in ./bug2.bro, line 7: illegal initializer ([[$resp_h=1.2.3.4]] =
12)
}}}
It probably should return an initialized table.
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
2 Nov
2 Nov
2:15 p.m.
New subject: [Bro-Dev] #660: Initializing a table with a record as an index does not work
#660: Initializing a table with a record as an index does not work
----------------------+-----------------
Reporter: amannb | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version:
Resolution: | Keywords:
----------------------+-----------------
Comment (by seth):
global my_table: table[irecord] of int = {
Using a record as an index on a table or set is usually not a good idea.
Lookups may not happen as you expect if you are using a different record
instance to index into the table or set since Bro isn't doing value
equality but actually looking for the same record.
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660#comment:0>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
2:55 p.m.
New subject: [Bro-Dev] #660: Initializing a table with a record as an index does not work
#660: Initializing a table with a record as an index does not work
----------------------+-----------------
Reporter: amannb | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version:
Resolution: | Keywords:
----------------------+-----------------
Comment (by robin):
On Wed, Nov 02, 2011 at 21:15 -0000, you wrote:
Using a record as an index on a table or set is
usually not a good
idea.
Lookups may not happen as you expect if you are using
a different
record
instance to index into the table or set since Bro
isn't doing value
equality but actually looking for the same record.
Are you sure? This works as I would expect it:
{{{
type r: record {
a: string;
};
global foo: table[r] of count;
global a: r = [$a="foo"];
global b: r = [$a="foo"];
global c: r = [$a="bar"];
foo[a] = 1;
print a in foo;
print b in foo;
print c in foo;
}}}
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660#comment:1>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
5:55 p.m.
New subject: [Bro-Dev] #660: Initializing a table with a record as an index does not work
#660: Initializing a table with a record as an index does not work
----------------------+-----------------
Reporter: amannb | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version:
Resolution: | Keywords:
----------------------+-----------------
Comment (by seth):
Are you sure? This works as I would expect it:
Damn, you're right. We should talk about finding some way to rethink
record and table initializers eventually. There are too many
inconsistencies with how they are done currently.
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660#comment:2>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
3 Nov
3 Nov
9:07 a.m.
New subject: [Bro-Dev] #660: Initializing a table with a record as an index does not work
#660: Initializing a table with a record as an index does not work
----------------------+----------------------
Reporter: amannb | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version:
Resolution: | Keywords: language
----------------------+----------------------
Changes (by robin):
* keywords: => language
Comment:
Yeah, and using a two-element record for ``r`` gives me parser error. :-(
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660#comment:3>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
12 Dec
12 Dec
1:09 p.m.
New subject: [Bro-Dev] #660: Initializing a table with a record as an index does not work
#660: Initializing a table with a record as an index does not work
----------------------+----------------------
Reporter: amannb | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version:
Resolution: | Keywords: language
----------------------+----------------------
Comment (by jsiwek):
In [f6d5da423cccc5585d191a3d48745977659eca79/bro]:
{{{
#!CommitTicketReference repository="bro"
revision="f6d5da423cccc5585d191a3d48745977659eca79"
Fix record constructors in table initializer indices. Addresses #660.
For an index expression list, ListExpr::InitVal() passed the TypeList
to Expr::InitVal() for each expression element in the list instead of
the type for that element. This made RecordConstructorExpr::InitVal()
complain since it expects a RecordType and not a TypeList with a
RecordType element as an argument. In most other cases, Expr::InitVal()
worked because check_and_promote() "flattens" the list to a single type.
}}}
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660#comment:4>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
1:10 p.m.
New subject: [Bro-Dev] #660: Initializing a table with a record as an index does not work
#660: Initializing a table with a record as an index does not work
----------------------------+----------------------
Reporter: amannb | Owner:
Type: Merge Request | Status: new
Priority: Normal | Milestone:
Component: Bro | Version:
Resolution: | Keywords: language
----------------------------+----------------------
Changes (by jsiwek):
* type: Problem => Merge Request
Comment:
Fix in `topic/jsiwek/table-init-record-idx`.
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/660#comment:5>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
3454
days inactive
3860
days old
6 comments
1 participants
participants (1)
-
Bro Tracker