zeek-dev December 2017

zeek-dev@lists.zeek.org

6 discussions

[Bro-Dev] SMB transaction messages pull request

by Bencteux Jeffrey

Hi all, I made a pull request a while ago to add/update messages for the SMB analyzer and I did not get no feedback. Is there something wrong with it? I'd be happy to modify it to fit your requirements if necessary. You can find it here : https://github.com/bro/bro/pull/119. Regards,

4 years

[Bro-Dev] Closures in Bro

by Jan Grashöfer

Hi everyone, playing around with the add-json package, I realized that I will need to "extend" functions like the path_func at some point. That is, I need to calculate a value using the original version of the function and "add" my calculations on top. My approach is to wrap the function, which works as long as I don't need "multiple versions" of that function. In the latter case closures would help, e.g.: function do_add(i: int): function(j: int): int { return function(j: int): int {return i+j; }; } However, referencing outer function IDs is not supported (see http://try.bro.org/#/trybro/saved/196147). In the light of the flexibility that comes with packages, I think supporting closures would be a nice feature. Was there any fundamental design decision against supporting closures? Jan

4 years

[Bro-Dev] netmap lb issues - not forwarding packets after a few min

by Scott Campbell

Currently running bro current (2.5-372) on a Scientific Linux release 6.9 kernel 2.6.32-696.13.2.el6.x86_64 . The bro netmap module was added per directions: bro@xdev-m ~/bin> ./bro -N Bro::Netmap Bro::Netmap - Packet acquisition via Netmap (dynamic, version 1.0) I downloaded and installed the current git netmap ( MODULE_INFO(srcversion, "70F039B58865AAE47076678") ) without issue, and there are no messages when the modules load besides what you would expect to see. What I am seeing is when I run the lb application it runs as expected for a few minutes, then stops forwarding packets and continues logging the same line regardless of how long you wait. Sample logs follow. lb starts: > [root@xdev-w1 lb]# ./lb -i eth5 -o 10 -p8 -B 1024 > 933.751533 main [600] interface is eth5 > 933.751614 main [621] requested 1024 extra buffers > 934.080683 main [714] successfully opened netmap:eth5 (tx rings: 512) > 934.080699 main [725] obtained 1024 extra buffers > 934.081586 main [784] opening pipe named netmap:eth5{0/xT@1 > 934.081627 nm_mmap [987] do not mmap, inherit from parent > 934.081639 main [799] successfully opened pipe #1 netmap:eth5{0/xT@1 (tx slots: 512) > 934.081646 main [803] zerocopy enabled > 934.081671 main [784] opening pipe named netmap:eth5{1/xT@1 > 934.081692 nm_mmap [987] do not mmap, inherit from parent > 934.081700 main [799] successfully opened pipe #2 netmap:eth5{1/xT@1 (tx slots: 512) > 934.081706 main [803] zerocopy enabled > 934.081729 main [784] opening pipe named netmap:eth5{2/xT@1 > 934.081746 nm_mmap [987] do not mmap, inherit from parent > 934.081754 main [799] successfully opened pipe #3 netmap:eth5{2/xT@1 (tx slots: 512) > 934.081760 main [803] zerocopy enabled > 934.081786 main [784] opening pipe named netmap:eth5{3/xT@1 > 934.081803 nm_mmap [987] do not mmap, inherit from parent > 934.081813 main [799] successfully opened pipe #4 netmap:eth5{3/xT@1 (tx slots: 512) > 934.081819 main [803] zerocopy enabled > 934.081842 main [784] opening pipe named netmap:eth5{4/xT@1 > 934.081862 nm_mmap [987] do not mmap, inherit from parent > 934.081870 main [799] successfully opened pipe #5 netmap:eth5{4/xT@1 (tx slots: 512) > 934.081876 main [803] zerocopy enabled > 934.081899 main [784] opening pipe named netmap:eth5{5/xT@1 > 934.081916 nm_mmap [987] do not mmap, inherit from parent > 934.081923 main [799] successfully opened pipe #6 netmap:eth5{5/xT@1 (tx slots: 512) > 934.081929 main [803] zerocopy enabled > 934.081954 main [784] opening pipe named netmap:eth5{6/xT@1 > 934.081972 nm_mmap [987] do not mmap, inherit from parent > 934.081980 main [799] successfully opened pipe #7 netmap:eth5{6/xT@1 (tx slots: 512) > 934.081986 main [803] zerocopy enabled > 934.082013 main [784] opening pipe named netmap:eth5{7/xT@1 > 934.082031 nm_mmap [987] do not mmap, inherit from parent > 934.082041 main [799] successfully opened pipe #8 netmap:eth5{7/xT@1 (tx slots: 512) > 934.082046 main [803] zerocopy enabled > {"ts":1513728945.082923,"interface":"netmap:eth5{0/xT@1","output_ring":0,"packets_forwarded":85397,"packets_dropped":0,"data_forward_rate_Mbps":160.3504,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":19.4110,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{1/xT@1","output_ring":1,"packets_forwarded":65319,"packets_dropped":0,"data_forward_rate_Mbps":29.0976,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":8.5940,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{2/xT@1","output_ring":2,"packets_forwarded":317351,"packets_dropped":1300,"data_forward_rate_Mbps":395.4482,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":35.4900,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{3/xT@1","output_ring":3,"packets_forwarded":100570,"packets_dropped":0,"data_forward_rate_Mbps":148.8784,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":16.3190,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{4/xT@1","output_ring":4,"packets_forwarded":75111,"packets_dropped":0,"data_forward_rate_Mbps":91.5148,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":11.4440,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{5/xT@1","output_ring":5,"packets_forwarded":66920,"packets_dropped":0,"data_forward_rate_Mbps":66.1700,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":8.0000,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{6/xT@1","output_ring":6,"packets_forwarded":143992,"packets_dropped":0,"data_forward_rate_Mbps":170.3500,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":17.5980,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5{7/xT@1","output_ring":7,"packets_forwarded":67032,"packets_dropped":0,"data_forward_rate_Mbps":29.2870,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":5.2020,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728945.082923,"interface":"netmap:eth5","output_ring":null,"packets_received":1035728,"packets_forwarded":921692,"packets_dropped":1300,"non_ip_packets":18,"data_forward_rate_Mbps":1091.0964,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":122.0570,"packet_drop_rate_kpps":0.0000,"free_buffer_slots":1024} > {"ts":1513728955.083739,"interface":"netmap:eth5{0/xT@1","output_ring":0,"packets_forwarded":517056,"packets_dropped":31870,"data_forward_rate_Mbps":583.9244,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":46.9350,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{1/xT@1","output_ring":1,"packets_forwarded":415852,"packets_dropped":0,"data_forward_rate_Mbps":583.7359,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":48.9310,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{2/xT@1","output_ring":2,"packets_forwarded":998058,"packets_dropped":1300,"data_forward_rate_Mbps":925.2677,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":106.8910,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{3/xT@1","output_ring":3,"packets_forwarded":836948,"packets_dropped":14154,"data_forward_rate_Mbps":1321.3131,"data_drop_rate_Mbps":15.6000,"packet_forward_rate_kpps":91.2690,"packet_drop_rate_kpps":1.0790,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{4/xT@1","output_ring":4,"packets_forwarded":409670,"packets_dropped":0,"data_forward_rate_Mbps":519.5414,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":40.8310,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{5/xT@1","output_ring":5,"packets_forwarded":395510,"packets_dropped":0,"data_forward_rate_Mbps":545.0672,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":42.6580,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{6/xT@1","output_ring":6,"packets_forwarded":555556,"packets_dropped":0,"data_forward_rate_Mbps":592.1166,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":47.5850,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5{7/xT@1","output_ring":7,"packets_forwarded":393490,"packets_dropped":0,"data_forward_rate_Mbps":515.1810,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":41.6850,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513728955.083739,"interface":"netmap:eth5","output_ring":null,"packets_received":5323612,"packets_forwarded":4522140,"packets_dropped":47324,"non_ip_packets":18,"data_forward_rate_Mbps":5586.1473,"data_drop_rate_Mbps":15.6000,"packet_forward_rate_kpps":466.7870,"packet_drop_rate_kpps":1.0790,"free_buffer_slots":1024} this continues for some time then : > {"ts":1513729195.106307,"interface":"netmap:eth5{0/xT@1","output_ring":0,"packets_forwarded":4920687,"packets_dropped":33825,"data_forward_rate_Mbps":10.7695,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":2.0180,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{1/xT@1","output_ring":1,"packets_forwarded":5930891,"packets_dropped":3760,"data_forward_rate_Mbps":47.3625,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":9.5640,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{2/xT@1","output_ring":2,"packets_forwarded":16009392,"packets_dropped":130519,"data_forward_rate_Mbps":849.3118,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":77.2920,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{3/xT@1","output_ring":3,"packets_forwarded":7001918,"packets_dropped":1337878,"data_forward_rate_Mbps":36.4586,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":5.6990,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{4/xT@1","output_ring":4,"packets_forwarded":5250042,"packets_dropped":1403,"data_forward_rate_Mbps":161.3338,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":17.7030,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{5/xT@1","output_ring":5,"packets_forwarded":5426001,"packets_dropped":0,"data_forward_rate_Mbps":67.0789,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":7.9150,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{6/xT@1","output_ring":6,"packets_forwarded":5991695,"packets_dropped":0,"data_forward_rate_Mbps":58.6742,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":7.5420,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5{7/xT@1","output_ring":7,"packets_forwarded":5094833,"packets_dropped":0,"data_forward_rate_Mbps":152.4217,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":15.5730,"packet_drop_rate_kpps":0.0000,"overflow_queue_size":0} > {"ts":1513729195.106307,"interface":"netmap:eth5","output_ring":null,"packets_received":62232503,"packets_forwarded":55625459,"packets_dropped":1507385,"non_ip_packets":413,"data_forward_rate_Mbps":1383.4110,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":143.3050,"packet_drop_rate_kpps":0.0000,"free_buffer_slots":1024} > {"ts":1513729195.106307,"interface":"netmap:eth5","output_ring":null,"packets_received":62232503,"packets_forwarded":55625459,"packets_dropped":1507385,"non_ip_packets":413,"data_forward_rate_Mbps":1383.4110,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":143.3050,"packet_drop_rate_kpps":0.0000,"free_buffer_slots":1024} > {"ts":1513729195.106307,"interface":"netmap:eth5","output_ring":null,"packets_received":62232503,"packets_forwarded":55625459,"packets_dropped":1507385,"non_ip_packets":413,"data_forward_rate_Mbps":1383.4110,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":143.3050,"packet_drop_rate_kpps":0.0000,"free_buffer_slots":1024} > {"ts":1513729195.106307,"interface":"netmap:eth5","output_ring":null,"packets_received":62232503,"packets_forwarded":55625459,"packets_dropped":1507385,"non_ip_packets":413,"data_forward_rate_Mbps":1383.4110,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":143.3050,"packet_drop_rate_kpps":0.0000,"free_buffer_slots":1024} > {"ts":1513729195.106307,"interface":"netmap:eth5","output_ring":null,"packets_received":62232503,"packets_forwarded":55625459,"packets_dropped":1507385,"non_ip_packets":413,"data_forward_rate_Mbps":1383.4110,"data_drop_rate_Mbps":0.0000,"packet_forward_rate_kpps":143.3050,"packet_drop_rate_kpps":0.0000,"free_buffer_slots":1024} The individual sub interfaces created by lb no longer report, but every 10 seconds (as configured) 9 identical lines (8 from -p 8 , and one from eth5) print out with the numbers no longer changing. Interface counters on eth5 continue to move so the interface is still seeing data. As well the time it takes for this to happen seems to vary. I have reloaded the modules, run lb as a user or root, changed the configuration parameters, rebooted the system all to no avail. Any thoughts? scott

4 years

Re: [Bro-Dev] [Bro-Commits] [git/broker] topic/actor-system: Add broker::bro::RelayEvent message type. (ce86016)

by Robin Sommer

Hi Jon, I'm curious what's the use case for this? Generally I think it's best to use a combination of Broker-internal forwarding and topics to control where messages get propagated too, as that will better generalize to larger topologies later. The less of the routing we control manually at the Bro level, the better I'd say. But that's not an absolute rule of course, and I may just be missing what this is aiming at. Robin On Thu, Dec 14, 2017 at 12:55 -0600, Jonathan Siwek wrote: > Repository : ssh://git@bro-ids.icir.org/broker > On branch : topic/actor-system > > >--------------------------------------------------------------- > > commit ce860168961285c6d961973aa9e1ef6b7de87887 > Author: Jon Siwek <jsiwek(a)corelight.com> > Date: Thu Dec 14 12:55:52 2017 -0600 > > Add broker::bro::RelayEvent message type. > > This is meant to be a more convenient/controlled/explicit way of doing > simple one-hop message forwarding. > > > >--------------------------------------------------------------- > > ce860168961285c6d961973aa9e1ef6b7de87887 > broker/bro.hh | 36 ++++++++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) > > diff --git a/broker/bro.hh b/broker/bro.hh > index 0d7f0e7..0ec93f2 100644 > --- a/broker/bro.hh > +++ b/broker/bro.hh > @@ -18,6 +18,7 @@ public: > LogWrite = 3, > IdentifierUpdate = 4, > Batch = 5, > + RelayEvent = 6, > }; > > Type type() const { > @@ -50,7 +51,7 @@ protected: > class Event : public Message { > public: > Event(std::string name, vector args) > - : Message(Message::Type::Event, {name, std::move(args)}) {} > + : Message(Message::Type::Event, {std::move(name), std::move(args)}) {} > Event(data msg) : Message(std::move(msg)) {} > > const std::string& name() const { > @@ -62,6 +63,30 @@ class Event : public Message { > } > }; > > +/// A Bro relayed event (automatically republished after a single hop). > +class RelayEvent : public Message { > + public: > + RelayEvent(set relay_topics, std::string name, vector args) > + : Message(Message::Type::RelayEvent, {std::move(relay_topics), > + std::move(name), > + std::move(args)}) > + {} > + RelayEvent(data msg) : Message(std::move(msg)) {} > + > + const set& topics() const { > + return get<set>(get<vector>(msg_[2])[0]); > + } > + > + const std::string& name() const { > + return get<std::string>(get<vector>(msg_[2])[1]); > + } > + > + const vector& args() const { > + return get<vector>(get<vector>(msg_[2])[2]); > + } > +}; > + > + > /// A batch of other messages. > class Batch : public Message { > public: > @@ -81,7 +106,8 @@ public: > LogCreate(enum_value stream_id, enum_value writer_id, data writer_info, > data fields_data) > : Message(Message::Type::LogCreate, > - {stream_id, writer_id, writer_info, fields_data}) { > + {std::move(stream_id), std::move(writer_id), > + std::move(writer_info), std::move(fields_data)}) { > } > > LogCreate(data msg) : Message(std::move(msg)) { > @@ -108,7 +134,8 @@ public: > LogWrite(enum_value stream_id, enum_value writer_id, data path, > data vals_data) > : Message(Message::Type::LogWrite, > - {stream_id, writer_id, path, vals_data}) { > + {std::move(stream_id), std::move(writer_id), > + std::move(path), std::move(vals_data)}) { > } > > LogWrite(data msg) : Message(std::move(msg)) { > @@ -131,7 +158,8 @@ public: > class IdentifierUpdate : public Message { > public: > IdentifierUpdate(std::string id_name, data id_value) > - : Message(Message::Type::IdentifierUpdate, {id_name, id_value}) { > + : Message(Message::Type::IdentifierUpdate, {std::move(id_name), > + std::move(id_value)}) { > } > > IdentifierUpdate(data msg) : Message(std::move(msg)) { > > > > _______________________________________________ > bro-commits mailing list > bro-commits(a)bro.org > http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-commits > -- Robin Sommer * ICSI/LBNL * robin(a)icir.org * www.icir.org/robin

4 years, 1 month

Re: [Bro-Dev] Feedback on configuration framework implementation

by Azoff, Justin S

> On Dec 7, 2017, at 5:22 PM, Johanna Amann <johanna(a)corelight.com> wrote: > Indeed, that is my thought. This seems like a job for broker, instead of trying to somehow force this into a complex ascii-representation. > > Note that this is just a limitation of the config reader - the rest of the config framework (that does not deal with file reading) does not care what you throw at it and will happily accept tables, etc. So if you get Broker to give you a table you should be able to just use the calls for setting options with that table afterwards. > > Johanna Cool.. so you figure something like a python script to load/organize your data from whatever upstream source you have, then just call Option::set using broker? I think the ascii representation of data structures would still help in a few places.. bro is in a weird place right now where we have json and 'print' that can output an ascii representation of almost any data structure, but what it outputs is not always valid bro code that can be parsed in the other direction. Like, const foo: table[subnet] of set[port] = { [192.168.0.0/24] = set(22/tcp) }; Gets turned into { [192.168.0.0/24] = { 22/tcp } } But the bro parser doesn't parse {...} as a set. and const foo: table[subnet] of vector of port = { [192.168.0.0/24] = vector(22/tcp) }; Gets turned into { [192.168.0.0/24] = [22/tcp] } But trying to parse that crashes: internal error in ././trybro.bro, line 2: missing aggregate in ListExpr::InitVal (22/tcp) — Justin Azoff

4 years, 1 month

[Bro-Dev] Feedback on configuration framework implementation

by Johanna Amann

Hello everyone, the branch topic/johanna/config contains an implementation of the configuration framework as it was discussed in an earlier thread on this list. GitHub link: https://github.com/bro/bro/compare/topic/johanna/config The implementation is basically what we discussed in the earlier thread with some additional components like a reader for configuration values and a script-level framework. It would be great if people could take a look at all of this and see if this makes sense, or if they see any problems with the implementation as it is at the moment. In the rest of the mail I wil go into a bit more detail and describe the different parts of this change. Note that the rest of this email will be very similar to the git commit message which also describes this change :) The configuration framework consists of three mostly distinct parts: * option variables * the config reader * the script level framework option variable =============== The option keyword allows variables to be specified as run-tine options. Such variables cannot be changed using normal assignments. Instead, they can be changed using Option::set. It is possible to "subscribe" to options and be notified when an option value changes. Change handlers can also change values before they are applied; this gives them the opportunity to reject changes. Priorities can be specified if there are several handlers for one option. Example script: option testbool: bool = T; function option_changed(ID: string, new_value: bool): bool { print fmt("Value of %s changed from %s to %s", ID, testbool, new_value); return new_value; } event bro_init() { print "Old value", testbool; Option::set_change_handler("testbool", option_changed); Option::set("testbool", F); print "New value", testbool; } config reader ============= The config reader provides a way to read configuration files back into Bro. Most importantly it automatically converts values to the correct types. This is important because it is at least inconvenient (and sometimes near impossible) to perform the necessary type conversions in Bro scripts themselves. This is especially true for sets/vectors. Configuration generally look like this: [option name][tab/spaces][new variable value] so, for example: testaddr 2607:f8b0:4005:801::200e testinterval 60 testtime 1507321987 test_set a b c d erdbeerschnitzel The reader uses the option name to look up the type that variable has in the Bro core and automatically converts the value to the correct type. Example script use: type Idx: record { option_name: string; }; type Val: record { option_val: string; }; global currconfig: table[string] of string = table(); event InputConfig::new_value(name: string, source: string, id: string, value: any) { print id, value; } event bro_init() { Input::add_table([$reader=Input::READER_CONFIG, $source="../configfile", $name="configuration", $idx=Idx, $val=Val, $destination=currconfig, $want_record=F]); } Script-level config framework ============================= The script-level framework ties these two features together and makes them a bit more convenient to use. Configuration files can simply be specified by placing them into Config::config_files. The framework also creates a config.log that shows all value changes that took place. Usage example: redef Config::config_files += {configfile}; export { option testbool : bool = F; } The file is now monitored for changes; when a change occurs the respective option values are automatically updated and the value change is written to config.log. Other changes ============= Internally, this commit also performs a range of changes to the Input manager; it marks a lot of functions as const and introduces a new ValueToVal method (which could in theory replace the already existing one - it is a bit more powerful). This also changes SerialTypes to have a subtype for Values, just as Fields already have it; I think it was mostly an oversight that this was not introduced from the beginning. This should not necessitate any code changes for people already using SerialTypes. Johanna

4 years, 1 month

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

zeek-dev December 2017