zeek-dev July 2015

zeek-dev@lists.zeek.org

90 discussions

by Robin Sommer

(Cc'ing bro-dev, I suggest we continue the thread there). This sounds generally reasonable, however I think we could take the opportunity here to generalize this a bit more for generally including link-layer information into connection handling. One thing that I didn't quite get form your description is if the objective is really just to get the VLAN ID into conn.log, or whether you also want to use it for defining what constitutes a connection in the first place. The latter would aim at the situations where the same IP addresses can appear on different VLANs for independent connections. Right now, Bro can't keep them apart, but if we made the VLAN part of the connection index into the session table, it would treat them separately. Same applies to other link-level features that could sometimes be useful to be a part of a connection's ID (like MAC addresses). With that in mind, some thoughts on generalizing this (note, I not sureif you're working from 2.3 or git master. The PktSrc API has changed a bit recently, I'll take git as my starting point). - One challenge is passing the the VLAN ID through to the various packet-related methods. You're suggesting additional parameters, which would work. However, these methods are already taking a bunch of parameters, and if in the future we wanted to pass through further link-layer info, we'd have to add even more. A more flexible alternative would be switching to simply passing a Packet structure around that encapsulates all the information, including what's already there (e.g., timestmap, pcap_hdr, payload, etc.). The new PktSrc API already has such a class: PktSrc::Packet; from a quick look I think we could elevate that to be something passed around more generally, and then extend it accordingly. - For the connections, I would store the VLAN inside the ConnID struct, and then modify BuildConnIDHashKey() to take it into account. That way, the session table will make it part of its index. Same for the script-land conn_id record; that will then make script-level tables work that index by conn_id. - Extending the ConnID like this could actually be made a run-time option: I believe it shouldn't be too difficult to let users chose the fields defining a ConnID, so that they can decide if, say, they want to VLAN to be in there or not. We could predefine a set of potential features to choose from, along with some script-land API to pick the set to use, with the current 4-tuple being the default. (This could be a 2nd step for later; if the first two points above were in place, this extension should become mainly a question of finding the right configuration interface.) I haven't thought this thruogh too carefully, so it's conceivable that I'm missing something. But I think it would be really helpful for many folks to get more flexibility into the definition of what consitutes a connection, with VLANs being a good initial target to support. Robin On Tue, Apr 14, 2015 at 16:59 +0000, you wrote: > Dear Bro developers, > > I've been tasked with trying to modify the Bro source code so that > conn.log includes the VLAN IDs (including 802.1ah) that have been observed > in packets associated with that connection. I've scoped out a solution, > but I want to run it by you first before I start to go for it, in case I'm > missing something really big. > > PktSrc::Process() does processing of VLAN and 802.1ah, but it just skips > over them by advancing the data pointer. I will, in addition, store those > VLAN IDs in a new member of the modified PktSrc class. This gets passed on > through net_packet_dispatch() and NetSessions::DispatchPacket(). At this > point NetSessions::NextPacket() gets called, but since the PktSrc doesn't > get passed to it, I'd need another way to pass it the VLAN ID. I am > considering two options: > > 1. duplicate NextPacket() adding a new parameter to pass it the VLAN IDs, > and call that instead, or > 2. store the VLAN IDs in the NetSessions class, in DispatchPacket() so > it¹s available to NextPacket() and DoNextPacket() <- Is there a reason > this wouldn¹t work, e.g. issues with multi-threading/multi-processing? > > Is there one option that seems better to you? > > NetSessions::DoNextPacket() is called next and I would also need a > modification to pass it VLAN IDs, using one of the options above. In this > method we finally get access to the appropriate Connection instance, so I > would store the VLAN IDs in that instance in DoNextPacket(). > > I'd need to modify the Connection class in Conn.h to include a new member > for tracking VLAN IDs. I'd modify Connection::BuildConnVal() and > scripts/base/init-bare.bro's connection record to make the VLAN IDs > available to scripts. Lastly, I'd write a script to redef the conn Info > structure and handle one or more connection events (perhaps > connection_state_remove) to copy the VLAN IDs from the connection record > to the Info record. > > Is there anything I'm missing? Is there a better way to approach this? > -- Robin Sommer * ICSI/LBNL * robin(a)icir.org * www.icir.org/robin

6 years, 3 months

[Bro-Dev] [JIRA] (BIT-1440) Remove perl from list of Bro build dependencies

by Daniel Thayer (JIRA)

[ https://bro-tracker.atlassian.net/browse/BIT-1440?page=com.atlassian.jira.p… ] Daniel Thayer updated BIT-1440: ------------------------------- Status: Merge Request (was: Open) > Remove perl from list of Bro build dependencies > ----------------------------------------------- > > Key: BIT-1440 > URL: https://bro-tracker.atlassian.net/browse/BIT-1440 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro > Reporter: Daniel Thayer > Fix For: 2.5 > > > Currently, perl is required to build Bro due to one small perl script. > Since that script doesn't rely on any special features of perl, it can > easily be rewritten to avoid the dependency on perl. This is mostly > relevant for FreeBSD, where perl is not installed by default. -- This message was sent by Atlassian JIRA (v6.5-OD-08-001#65007)

6 years, 5 months

[Bro-Dev] [JIRA] (BIT-1440) Remove perl from list of Bro build dependencies

by Daniel Thayer (JIRA)

[ https://bro-tracker.atlassian.net/browse/BIT-1440?page=com.atlassian.jira.p… ] Daniel Thayer commented on BIT-1440: ------------------------------------ Branch topic/dnthayer/ticket1440 in the bro git repo contains the necessary changes. > Remove perl from list of Bro build dependencies > ----------------------------------------------- > > Key: BIT-1440 > URL: https://bro-tracker.atlassian.net/browse/BIT-1440 > Project: Bro Issue Tracker > Issue Type: Problem > Components: Bro > Reporter: Daniel Thayer > Fix For: 2.5 > > > Currently, perl is required to build Bro due to one small perl script. > Since that script doesn't rely on any special features of perl, it can > easily be rewritten to avoid the dependency on perl. This is mostly > relevant for FreeBSD, where perl is not installed by default. -- This message was sent by Atlassian JIRA (v6.5-OD-08-001#65007)

6 years, 5 months

[Bro-Dev] [JIRA] (BIT-1440) Remove perl from list of Bro build dependencies

by Daniel Thayer (JIRA)

Daniel Thayer created BIT-1440: ---------------------------------- Summary: Remove perl from list of Bro build dependencies Key: BIT-1440 URL: https://bro-tracker.atlassian.net/browse/BIT-1440 Project: Bro Issue Tracker Issue Type: Problem Components: Bro Reporter: Daniel Thayer Fix For: 2.5 Currently, perl is required to build Bro due to one small perl script. Since that script doesn't rely on any special features of perl, it can easily be rewritten to avoid the dependency on perl. This is mostly relevant for FreeBSD, where perl is not installed by default. -- This message was sent by Atlassian JIRA (v6.5-OD-08-001#65007)

6 years, 5 months

[Bro-Dev] [Auto] Merge Status

by Merge Tracker

Open Merge Requests =================== ID Component Reporter Assignee Updated For Version Priority Summary ------------ ----------- ------------- ---------- ---------- ------------- ---------- --------------------------------------- BIT-1439 [1] bro-aux Daniel Thayer - 2015-07-30 2.5 Normal bro-cut segfaults for some invalid logs Open GitHub Pull Requests ========================= Issue Component User Updated Title ------- ----------- --------------------- ---------- ---------------------------------------------------------------------------------- #37 [2] bro albertzaharovits [3] 2015-07-28 [BIT-1429] The SMTP logs should include CC: addresses as well as To: addresses [4] #36 [5] bro jswaro [6] 2015-07-27 Add hook 'HookAddToAnalyzerTree' to support TCPRS plugin [7] #5 [8] bro-plugins jswaro [9] 2015-07-26 Adding initial conversion of TCPRS to a plugin [10] #3 [11] bro-plugins albertzaharovits [12] 2015-07-17 Redis Log Writer [13] [1] BIT-1439 https://bro-tracker.atlassian.net/browse/BIT-1439 [2] Pull Request #37 https://github.com/bro/bro/pull/37 [3] albertzaharovits https://github.com/albertzaharovits [4] Merge Pull Request #37 with git pull --no-ff --no-commit https://github.com/albertzaharovits/bro.git master [5] Pull Request #36 https://github.com/bro/bro/pull/36 [6] jswaro https://github.com/jswaro [7] Merge Pull Request #36 with git pull --no-ff --no-commit https://github.com/jswaro/bro.git topic/jswaro/feature/HookAddToAnalyzer-tcprs-support [8] Pull Request #5 https://github.com/bro/bro-plugins/pull/5 [9] jswaro https://github.com/jswaro [10] Merge Pull Request #5 with git pull --no-ff --no-commit https://github.com/jswaro/bro-plugins.git topic/jswaro/feature/initial-tcprs-plugin [11] Pull Request #3 https://github.com/bro/bro-plugins/pull/3 [12] albertzaharovits https://github.com/albertzaharovits [13] Merge Pull Request #3 with git pull --no-ff --no-commit https://github.com/albertzaharovits/bro-plugins.git master

6 years, 5 months

[Bro-Dev] [JIRA] (BIT-1439) bro-cut segfaults for some invalid logs

by Daniel Thayer (JIRA)

[ https://bro-tracker.atlassian.net/browse/BIT-1439?page=com.atlassian.jira.p… ] Daniel Thayer commented on BIT-1439: ------------------------------------ Branch topic/jazoff/bro-cut-crash-fixes in the bro-aux git repo contains fixes and also some new test cases. I also added a few more fixes for a few obscure bugs. > bro-cut segfaults for some invalid logs > --------------------------------------- > > Key: BIT-1439 > URL: https://bro-tracker.atlassian.net/browse/BIT-1439 > Project: Bro Issue Tracker > Issue Type: Problem > Components: bro-aux > Reporter: Daniel Thayer > Fix For: 2.5 > > > Justin was testing bro-cut and found a few cases where an invalid log file > could trigger a segfault. -- This message was sent by Atlassian JIRA (v6.5-OD-08-001#65007)

6 years, 5 months

[Bro-Dev] [JIRA] (BIT-1439) bro-cut segfaults for some invalid logs

by Daniel Thayer (JIRA)

[ https://bro-tracker.atlassian.net/browse/BIT-1439?page=com.atlassian.jira.p… ] Daniel Thayer updated BIT-1439: ------------------------------- Status: Merge Request (was: Open) > bro-cut segfaults for some invalid logs > --------------------------------------- > > Key: BIT-1439 > URL: https://bro-tracker.atlassian.net/browse/BIT-1439 > Project: Bro Issue Tracker > Issue Type: Problem > Components: bro-aux > Reporter: Daniel Thayer > Fix For: 2.5 > > > Justin was testing bro-cut and found a few cases where an invalid log file > could trigger a segfault. -- This message was sent by Atlassian JIRA (v6.5-OD-08-001#65007)

6 years, 5 months

[Bro-Dev] [JIRA] (BIT-1439) bro-cut segfaults for some invalid logs

by Daniel Thayer (JIRA)

Daniel Thayer created BIT-1439: ---------------------------------- Summary: bro-cut segfaults for some invalid logs Key: BIT-1439 URL: https://bro-tracker.atlassian.net/browse/BIT-1439 Project: Bro Issue Tracker Issue Type: Problem Components: bro-aux Reporter: Daniel Thayer Fix For: 2.5 Justin was testing bro-cut and found a few cases where an invalid log file could trigger a segfault. -- This message was sent by Atlassian JIRA (v6.5-OD-08-001#65007)

6 years, 5 months

[Bro-Dev] Developing a simplified Bro IDS

by Fun Ray

Hi! I'm trying to develop a simplified Bro IDS on ClickOS. Can anyone help me to identify some of the core source code that is about the event engine and scrip interpreter? Thanks! Ray

6 years, 5 months

[Bro-Dev] [Auto] Merge Status

by Merge Tracker

Open GitHub Pull Requests ========================= Issue Component User Updated Title ------- ----------- --------------------- ---------- ---------------------------------------------------------------------------------- #37 [1] bro albertzaharovits [2] 2015-07-28 [BIT-1429] The SMTP logs should include CC: addresses as well as To: addresses [3] #36 [4] bro jswaro [5] 2015-07-27 Add hook 'HookAddToAnalyzerTree' to support TCPRS plugin [6] #35 [7] bro J-Gras [8] 2015-07-29 Updated detection of Flash and AdobeAIR. [9] #5 [10] bro-plugins jswaro [11] 2015-07-26 Adding initial conversion of TCPRS to a plugin [12] #3 [13] bro-plugins albertzaharovits [14] 2015-07-17 Redis Log Writer [15] [1] Pull Request #37 https://github.com/bro/bro/pull/37 [2] albertzaharovits https://github.com/albertzaharovits [3] Merge Pull Request #37 with git pull --no-ff --no-commit https://github.com/albertzaharovits/bro.git master [4] Pull Request #36 https://github.com/bro/bro/pull/36 [5] jswaro https://github.com/jswaro [6] Merge Pull Request #36 with git pull --no-ff --no-commit https://github.com/jswaro/bro.git topic/jswaro/feature/HookAddToAnalyzer-tcprs-support [7] Pull Request #35 https://github.com/bro/bro/pull/35 [8] J-Gras https://github.com/J-Gras [9] Merge Pull Request #35 with git pull --no-ff --no-commit https://github.com/J-Gras/bro.git topic/jgras/flash-detection [10] Pull Request #5 https://github.com/bro/bro-plugins/pull/5 [11] jswaro https://github.com/jswaro [12] Merge Pull Request #5 with git pull --no-ff --no-commit https://github.com/jswaro/bro-plugins.git topic/jswaro/feature/initial-tcprs-plugin [13] Pull Request #3 https://github.com/bro/bro-plugins/pull/3 [14] albertzaharovits https://github.com/albertzaharovits [15] Merge Pull Request #3 with git pull --no-ff --no-commit https://github.com/albertzaharovits/bro-plugins.git master

6 years, 5 months

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

zeek-dev July 2015