Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ----------- ------------------ ------------ ---------- ------------- ---------- --------------------------------------------------------
BIT-757 [1] Bro Matthias Vallentin Robin Sommer 2015-01-21 2.4 Normal Change split* to return a string_vec rather string_array
[1] BIT-757 https://bro-tracker.atlassian.net/browse/BIT-757
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ----------- ------------------ ------------ ---------- ------------- ---------- --------------------------------------------------------
BIT-757 [1] Bro Matthias Vallentin Robin Sommer 2015-01-21 2.4 Normal Change split* to return a string_vec rather string_array
[1] BIT-757 https://bro-tracker.atlassian.net/browse/BIT-757
Aashish Sharma created BIT-1306:
-----------------------------------
Summary: bro process would get stuck/freeze with myricom drivers
Key: BIT-1306
URL: https://bro-tracker.atlassian.net/browse/BIT-1306
Project: Bro Issue Tracker
Issue Type: Problem
Components: Bro
Affects Versions: git/master
Environment: OS: FreeBSD 9.3-RELEASE-p5 OS
bro version 2.3-328
git log -1 --format="%H"
379593c7fded0f9791ae71a52dd78a4c9d5a2c1f
Reporter: Aashish Sharma
When I stop bro (in cluster mode), one of the bro worker process (random) would get stuck and wouldn't shutdown, stop or even be killed using kill -s 9.
System has to be ultimately rebooted to remove stuck bro process.
On running myri_start_stop I see:
# /usr/local/opt/snf/sbin/myri_start_stop stop
Removing myri_snf.ko
kldunload: can't unload file: Device busy
It appears that the myri_snf.ko driver cannot be unloaded because of the stuck bro process. That process still has an open descriptor on the Sniffer device/driver and bro process freezes
More details:
The bro process is stuck in RNE state
R Marks a runnable process.
N The process has reduced CPU scheduling priority (see setpriority(2)).
E The process is trying to exit.
Here is an example:
### stuck process:
[bro@01 ~]$ ps auxwww | fgrep 1616
bro 1616 100.0 0.0 758040 60480 ?? RNE 2:57PM 53:50.04 /usr/local/bro-git/bin/bro -i myri0 -U .status -p broctl -p broctl-live -p local -p worker-1-1 mgr.bro broctl base/frameworks/cluster local-worker.bro broctl/auto
####when checking for process in proc:
[bro@c ~]$ ls -l /proc/1616
ls: /proc/1616: No such file or directory
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
Jon Siwek created BIT-1305:
------------------------------
Summary: Consider marking some attributes as deprecated
Key: BIT-1305
URL: https://bro-tracker.atlassian.net/browse/BIT-1305
Project: Bro Issue Tracker
Issue Type: Problem
Components: Bro
Reporter: Jon Siwek
Fix For: 2.4
Likely candidates for deprecation:
&rotate_interval
&rotate_size
&encrypt
&mergeable
&synchronize
&persistent
&group
While the mechanism I added in BIT-757 can't be used to mark attributes as deprecated, I'm thinking it's not difficult to just hard code the scanner to emit a warning when encountering certain attributes.
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
With latest master, I'm seeing larger-than-usual runtimes on the parts
of the test-suite. Not quite sure when that started, any idea?
[ 71%] tests.ipv6 ... failed (+2.5%)
[ 85%] tests.m57-long ... failed (+1.2%)
(Sometimes other external tests trigger the threshold too, it's a bit
inconsistent; but normally, none does).
Robin
--
Robin Sommer * ICSI/LBNL * robin(a)icir.org * www.icir.org/robin
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ----------- ------------------ ------------ ---------- ------------- ---------- --------------------------------------------------------
BIT-757 [1] Bro Matthias Vallentin Robin Sommer 2015-01-21 2.4 Normal Change split* to return a string_vec rather string_array
Open Fastpath Commits
======================
Commit Component Author Date Summary
----------- ----------- ------------- ---------- ----------------------------
f7085cb [2] btest Daniel Thayer 2015-01-19 Fix some typos in the README
[1] BIT-757 https://bro-tracker.atlassian.net/browse/BIT-757
[2] f7085cb https://github.com/bro/btest/commit/f7085cb940eda911b55a97949b80b71a13d98c92
[ https://bro-tracker.atlassian.net/browse/BIT-757?page=com.atlassian.jira.pl… ]
Jon Siwek commented on BIT-757:
-------------------------------
See topic/jsiwek/deprecation in bro, bro-testing, and bro-testing-private. It adds the deprecation mechanism and deprecates split* and related functions in favor of alternatives that use a string_vec.
> Change split* to return a string_vec rather string_array
> --------------------------------------------------------
>
> Key: BIT-757
> URL: https://bro-tracker.atlassian.net/browse/BIT-757
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: git/master
> Reporter: Matthias Vallentin
> Assignee: Robin Sommer
> Labels: language
> Fix For: 2.4
>
>
> Currently, `{{split}}{{ and friends return a }}{{string_array}}{{, which is a }}{{table[count] of string}}{{. However, these BiFs should return a }}{{string_vec}}{{ or }}{{vector of string}}{{ to allow for sequential iteration over the result. The problem with the current approach is not only that it is wrong modeled (the associative container does not make sense), but also that iteration over the elements, which are obviously ordered, is neither deterministic nor sequential. Presumably this mismatch exists because vectors were not available when the }}{{split*}}` functions have been created.
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-757?page=com.atlassian.jira.pl… ]
Jon Siwek reassigned BIT-757:
-----------------------------
Assignee: Robin Sommer (was: Jon Siwek)
> Change split* to return a string_vec rather string_array
> --------------------------------------------------------
>
> Key: BIT-757
> URL: https://bro-tracker.atlassian.net/browse/BIT-757
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: git/master
> Reporter: Matthias Vallentin
> Assignee: Robin Sommer
> Labels: language
> Fix For: 2.4
>
>
> Currently, `{{split}}{{ and friends return a }}{{string_array}}{{, which is a }}{{table[count] of string}}{{. However, these BiFs should return a }}{{string_vec}}{{ or }}{{vector of string}}{{ to allow for sequential iteration over the result. The problem with the current approach is not only that it is wrong modeled (the associative container does not make sense), but also that iteration over the elements, which are obviously ordered, is neither deterministic nor sequential. Presumably this mismatch exists because vectors were not available when the }}{{split*}}` functions have been created.
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-757?page=com.atlassian.jira.pl… ]
Jon Siwek updated BIT-757:
--------------------------
Status: Merge Request (was: Open)
> Change split* to return a string_vec rather string_array
> --------------------------------------------------------
>
> Key: BIT-757
> URL: https://bro-tracker.atlassian.net/browse/BIT-757
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: git/master
> Reporter: Matthias Vallentin
> Assignee: Robin Sommer
> Labels: language
> Fix For: 2.4
>
>
> Currently, `{{split}}{{ and friends return a }}{{string_array}}{{, which is a }}{{table[count] of string}}{{. However, these BiFs should return a }}{{string_vec}}{{ or }}{{vector of string}}{{ to allow for sequential iteration over the result. The problem with the current approach is not only that it is wrong modeled (the associative container does not make sense), but also that iteration over the elements, which are obviously ordered, is neither deterministic nor sequential. Presumably this mismatch exists because vectors were not available when the }}{{split*}}` functions have been created.
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)