[ https://bro-tracker.atlassian.net/browse/BIT-757?page=com.atlassian.jira.pl… ]
Robin Sommer updated BIT-757:
-----------------------------
Resolution: Merged (was: Fixed)
Status: Closed (was: Merge Request)
> Change split* to return a string_vec rather string_array
> --------------------------------------------------------
>
> Key: BIT-757
> URL: https://bro-tracker.atlassian.net/browse/BIT-757
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: git/master
> Reporter: Matthias Vallentin
> Assignee: Robin Sommer
> Labels: language
> Fix For: 2.4
>
>
> Currently, `{{split}}{{ and friends return a }}{{string_array}}{{, which is a }}{{table[count] of string}}{{. However, these BiFs should return a }}{{string_vec}}{{ or }}{{vector of string}}{{ to allow for sequential iteration over the result. The problem with the current approach is not only that it is wrong modeled (the associative container does not make sense), but also that iteration over the elements, which are obviously ordered, is neither deterministic nor sequential. Presumably this mismatch exists because vectors were not available when the }}{{split*}}` functions have been created.
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ----------- ------------------ ------------ ---------- ------------- ---------- --------------------------------------------------------
BIT-757 [1] Bro Matthias Vallentin Robin Sommer 2015-01-21 2.4 Normal Change split* to return a string_vec rather string_array
[1] BIT-757 https://bro-tracker.atlassian.net/browse/BIT-757
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ----------- ------------------ ------------ ---------- ------------- ---------- --------------------------------------------------------
BIT-757 [1] Bro Matthias Vallentin Robin Sommer 2015-01-21 2.4 Normal Change split* to return a string_vec rather string_array
[1] BIT-757 https://bro-tracker.atlassian.net/browse/BIT-757
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
jdonnelly updated BIT-1307:
---------------------------
Resolution: Fixed
Status: Closed (was: Open)
using pcap installed from source ( in /usr/local/ ) was the problem.
Oops
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
jdonnelly commented on BIT-1307:
--------------------------------
removing /usr/local pcap files fixed it !
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
Jon Siwek commented on BIT-1307:
--------------------------------
What version of libpcap is installed in /usr/local? I don't expect that came from the OS.
If it's actually the one you want, `./configure --with-pcap=/usr` should get it to use the standard one coming from the OS.
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
jdonnelly commented on BIT-1307:
--------------------------------
Looks like it is picking up /usr/local
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
jdonnelly commented on BIT-1307:
--------------------------------
root@dyn-x64-01:/work/jpd/dyn/src/bro-fork/bro# grep PCAP build/CMakeCache.txt
PCAP_INCLUDE_DIR:PATH=/usr/local/include
PCAP_LIBRARY:FILEPATH=/usr/local/lib/libpcap.a
PCAP_ROOT_DIR:PATH=/usr/local
//Details about finding PCAP
FIND_PACKAGE_MESSAGE_DETAILS_PCAP:INTERNAL=[/usr/local/lib/libpcap.a][/usr/local/include][v()]
HAVE_LIBPCAP_PCAP_FREECODE:INTERNAL=1
HAVE_PCAP_INT_H:INTERNAL=
//Test LIBPCAP_PCAP_COMPILE_NOPCAP_HAS_ERROR_PARAMETER
LIBPCAP_PCAP_COMPILE_NOPCAP_HAS_ERROR_PARAMETER:INTERNAL=
//Test LIBPCAP_PCAP_COMPILE_NOPCAP_NO_ERROR_PARAMETER
LIBPCAP_PCAP_COMPILE_NOPCAP_NO_ERROR_PARAMETER:INTERNAL=1
//ADVANCED property for variable: PCAP_INCLUDE_DIR
PCAP_INCLUDE_DIR-ADVANCED:INTERNAL=1
//ADVANCED property for variable: PCAP_LIBRARY
PCAP_LIBRARY-ADVANCED:INTERNAL=1
//Test PCAP_LINKS_SOLO
PCAP_LINKS_SOLO:INTERNAL=1
//ADVANCED property for variable: PCAP_ROOT_DIR
PCAP_ROOT_DIR-ADVANCED:INTERNAL=1
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
Jon Siwek commented on BIT-1307:
--------------------------------
After `./configure`, what's the output of `grep PCAP build/CMakeCache.txt` ?
And does that actually point to the expected pcap library/headers? i.e. do you have more than one libpcap version installed and is it picking up the right one?
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)
[ https://bro-tracker.atlassian.net/browse/BIT-1307?page=com.atlassian.jira.p… ]
jdonnelly commented on BIT-1307:
--------------------------------
I went back to a older version of bro:
root@dyn-x64-01:/work/jpd/dyn/src/brotest# cat VERSION
2.3-238
And it fails too with the same PCAP error . ;-/
> bro build fails when pulled from git
> ------------------------------------
>
> Key: BIT-1307
> URL: https://bro-tracker.atlassian.net/browse/BIT-1307
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: jdonnelly
> Fix For: 2.4
>
>
> If a package is missing the configure step should find it.
> I am getting this error on a fresh checkout:
> git clone --recursive
> cd bro
> ./configure --enable-debug
> make[3]: Entering directory `/work/jpd/dyn/src/bro-fork/bro/build'
> [ 20%] Building CXX object src/analyzer/protocol/bittorrent/CMakeFs/plugin-Bro-BitTorrent.dir/BitTorrent.cc.o
> In file included from /work/jpd/dyn/src/bro-fork/bro/src/Net.h:12:0,
> from /work/jpd/dyn/src/bro-fork/bro/src/RuleMatcher.h:15,
> from /work/jpd/dyn/src/bro-fork/bro/src/Conn.h:13,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/tcp/TCP.h:11,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.h:6,
> from /work/jpd/dyn/src/bro-fork/bro/src/analyzer/protocol/bittorrent/BitTorrent.cc:3:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h: In constructor ‘iosource::PktSrc::Properties::Properties()’:
> /work/jpd/dyn/src/bro-fork/bro/src/iosource/PktSrc.h:272:14: error: ‘PCAP_NETMASK_UNKNOWN’ was not declared in this scope
> netmask = PCAP_NETMASK_UNKNOWN;
--
This message was sent by Atlassian JIRA
(v6.4-OD-13-026#64011)