It seems like one area where our documentation is sorely lacking is the
weirds. Apart from comments in the code, I believe the only documentation
is the name of the weird itself.
Is there a mechanism in Broxygen to document weirds? If not, has anyone
thought about what such a mechanism might look like?
--Vlad
Nicholas Weaver created BIT-1213:
------------------------------------
Summary: broccoli/bindings/broccoli-python not building correctly
Key: BIT-1213
URL: https://bro-tracker.atlassian.net/browse/BIT-1213
Project: Bro Issue Tracker
Issue Type: Problem
Components: broccoli-python
Affects Versions: 2.3
Environment: OS-X 10.9.3
Reporter: Nicholas Weaver
The setup.py routine fails due to path changes in 2.3, namely that the broccoli.h file is now in ../../build/src, as is the resulting library.
This patch appears to work:
diff --git a/setup.py b/setup.py
index 8a017f1..9cd19ae 100755
--- a/setup.py
+++ b/setup.py
@@ -12,8 +12,8 @@ setup(name="broccoli-python",
py_modules=['broccoli'],
ext_modules = [
Extension("_broccoli_intern", ["broccoli_intern_wrap.c"],
- include_dirs=["../../src"],
- library_dirs=["../../src/.libs"],
+ include_dirs=["../../build/src"],
+ library_dirs=["../../build/src"],
libraries=["broccoli"])]
)
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Johanna Amann commented on BIT-1212:
------------------------------------
Hello Marek,
would it perhaps be possible to create a test pcap that produces the crash? When I connect to ocsp.digicert.com:443 and request ocsp stapling, everything seems to work as expected (example trace at http://www.icir.org/johanna/traces/ocsp-stapling-digicert.pcap).
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Marek Balint commented on BIT-1212:
-----------------------------------
Hi, the server is ocsp.digicert.com.
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Johanna Amann commented on BIT-1212:
------------------------------------
May I ask which server you encountered this bug with? That might make writing a testcase a bit easier...
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Johanna Amann commented on BIT-1212:
------------------------------------
Ah, sorry, you are right. That apparently is another special case I did not come accross (or think of) during my tests. :/
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Marek Balint commented on BIT-1212:
-----------------------------------
It is released 2.3 (not beta). The file in question is on ff00c0786af01bddc8aa5b455edbb214ff06c4e7.
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Johanna Amann commented on BIT-1212:
------------------------------------
Hi. May I ask which version of Bro you are using? This seems to have been fixed before the 2.3 release (I think it was fixed inbetween the beta and the final release).
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Johanna Amann reassigned BIT-1212:
----------------------------------
Assignee: Johanna Amann
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
> Assignee: Johanna Amann
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)
[ https://bro-tracker.atlassian.net/browse/BIT-1212?page=com.atlassian.jira.p… ]
Marek Balint commented on BIT-1212:
-----------------------------------
That should be "basic->certs" (not "base->certs" - typo in Description) in call to sk_X509_push.
> Segfault in X509 file analyzer
> ------------------------------
>
> Key: BIT-1212
> URL: https://bro-tracker.atlassian.net/browse/BIT-1212
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Reporter: Marek Balint
>
> Bro segfaults in src/file_analysis/x509/functions.bif:256, due to base->certs being NULL.
--
This message was sent by Atlassian JIRA
(v6.3-OD-07-013#6327)