Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
------------ ------------------------------------ ------------- ------------- ---------- ------------- ---------- ----------------------------------------------------
BIT-1296 [1] Bro Daniel Thayer Robin Sommer 2014-12-02 2.4 Normal Bro segfault when using "@if" inside event handler
BIT-1295 [2] Bro Daniel Thayer Robin Sommer 2014-12-02 2.4 Normal core dump when attempting to assign via string index
BIT-856 [3] Bro,bro-aux,BroControl,trace-summary Vern Paxson Daniel Thayer 2014-12-01 2.4 Normal more documentation for utilities would be cool
Open Fastpath Commits
======================
Commit Component Author Date Summary
----------- ----------- ------------- ---------- ------------------------------------------------------
cc7286b [4] bro Daniel Thayer 2014-12-01 Fix some "make doc" warnings and update some doc tests
[1] BIT-1296 https://bro-tracker.atlassian.net/browse/BIT-1296
[2] BIT-1295 https://bro-tracker.atlassian.net/browse/BIT-1295
[3] BIT-856 https://bro-tracker.atlassian.net/browse/BIT-856
[4] cc7286b https://github.com/bro/bro/commit/cc7286b628be8556773810d705c6bbfd5b44e6d7
[ https://bro-tracker.atlassian.net/browse/BIT-1296?page=com.atlassian.jira.p… ]
Jon Siwek commented on BIT-1296:
--------------------------------
"@if" should work inside event handlers, it's just the attached test case's condition referenced a local variable. We can't generally make a parse-time decision about local state, so in topic/jsiwek/bit-1296, I've made it an error to reference local variables inside the "@if" condition.
Could even think about making it require references to consts only. Technically, I don't think there's any problem with globals, but it does require the programmer to realize it's the parse-time value of the global that's going to be used, not what the run-time value is when that code path is executed (one could just use a regular "if" statement for the later). And currently it looks like there's scripts that depend on "@if" evaluating globals. Not that it's hard to change those to use const, but there's probably a more general task to convert global functions into const functions where the intent is that they'll never be re-assigned.
> Bro segfault when using "@if" inside event handler
> --------------------------------------------------
>
> Key: BIT-1296
> URL: https://bro-tracker.atlassian.net/browse/BIT-1296
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: Daniel Thayer
> Fix For: 2.4
>
> Attachments: test.bro
>
>
> The attached script causes Bro to segfault.
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-012#64007)
[ https://bro-tracker.atlassian.net/browse/BIT-1296?page=com.atlassian.jira.p… ]
Daniel Thayer commented on BIT-1296:
------------------------------------
Not sure if "@if" in an event handler should work, or if Bro should just report an error.
> Bro segfault when using "@if" inside event handler
> --------------------------------------------------
>
> Key: BIT-1296
> URL: https://bro-tracker.atlassian.net/browse/BIT-1296
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: Daniel Thayer
> Attachments: test.bro
>
>
> The attached script causes Bro to segfault.
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-012#64007)
[ https://bro-tracker.atlassian.net/browse/BIT-1295?page=com.atlassian.jira.p… ]
Daniel Thayer commented on BIT-1295:
------------------------------------
I did not expect that assignment to a string index would work, just noticed that it dumped core.
> core dump when attempting to assign via string index
> ----------------------------------------------------
>
> Key: BIT-1295
> URL: https://bro-tracker.atlassian.net/browse/BIT-1295
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: Daniel Thayer
> Assignee: Robin Sommer
> Fix For: 2.4
>
> Attachments: test.bro
>
>
> The attached script causes Bro to dump core.
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-012#64007)
[ https://bro-tracker.atlassian.net/browse/BIT-1295?page=com.atlassian.jira.p… ]
Jon Siwek reassigned BIT-1295:
------------------------------
Assignee: Robin Sommer
> core dump when attempting to assign via string index
> ----------------------------------------------------
>
> Key: BIT-1295
> URL: https://bro-tracker.atlassian.net/browse/BIT-1295
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Reporter: Daniel Thayer
> Assignee: Robin Sommer
> Fix For: 2.4
>
> Attachments: test.bro
>
>
> The attached script causes Bro to dump core.
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-012#64007)