[ https://bro-tracker.atlassian.net/browse/BIT-1298?page=com.atlassian.jira.p… ]
Eric Asselin updated BIT-1298:
------------------------------
Attachment: core.zip
It use NTP analyzer and ip->SrcAddr().AsString() in the DeliverPacket method to trigger the segmentation fault
> IP_Hdr pointer do not propagate from udp to child analyzers via DeliverPacket method causing a segfault
> -------------------------------------------------------------------------------------------------------
>
> Key: BIT-1298
> URL: https://bro-tracker.atlassian.net/browse/BIT-1298
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Environment: Debian
> Reporter: Eric Asselin
> Priority: High
> Labels: analyzer
> Attachments: core.zip
>
>
> From a child analyzer like NTP, the IP_Hdr pointer in the DeliverPacket method is empty and unusable causing a segmentation fault as soon as you try to access it.
> To recreate the bug, just add an "assert(ip)" inside the DeliverPacket method of a UDP child analyzer and the execution will fail (instead of the segmentation fault).
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-014#64007)
[ https://bro-tracker.atlassian.net/browse/BIT-1298?page=com.atlassian.jira.p… ]
Eric Asselin edited comment on BIT-1298 at 12/9/14 7:49 AM:
------------------------------------------------------------
The core dump file use NTP analyzer and ip->SrcAddr().AsString() in the DeliverPacket method to trigger the segmentation fault
was (Author: easselin):
It use NTP analyzer and ip->SrcAddr().AsString() in the DeliverPacket method to trigger the segmentation fault
> IP_Hdr pointer do not propagate from udp to child analyzers via DeliverPacket method causing a segfault
> -------------------------------------------------------------------------------------------------------
>
> Key: BIT-1298
> URL: https://bro-tracker.atlassian.net/browse/BIT-1298
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.3
> Environment: Debian
> Reporter: Eric Asselin
> Priority: High
> Labels: analyzer
> Attachments: core.zip
>
>
> From a child analyzer like NTP, the IP_Hdr pointer in the DeliverPacket method is empty and unusable causing a segmentation fault as soon as you try to access it.
> To recreate the bug, just add an "assert(ip)" inside the DeliverPacket method of a UDP child analyzer and the execution will fail (instead of the segmentation fault).
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-014#64007)
Eric Asselin created BIT-1298:
---------------------------------
Summary: IP_Hdr pointer do not propagate from udp to child analyzers via DeliverPacket method causing a segfault
Key: BIT-1298
URL: https://bro-tracker.atlassian.net/browse/BIT-1298
Project: Bro Issue Tracker
Issue Type: Problem
Components: Bro
Affects Versions: 2.3
Environment: Debian
Reporter: Eric Asselin
Priority: High
>From a child analyzer like NTP, the IP_Hdr pointer in the DeliverPacket method is empty and unusable causing a segmentation fault as soon as you try to access it.
To recreate the bug, just add an "assert(ip)" inside the DeliverPacket method of a UDP child analyzer and the execution will fail (instead of the segmentation fault).
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-014#64007)
[ https://bro-tracker.atlassian.net/browse/BIT-856?page=com.atlassian.jira.pl… ]
Robin Sommer updated BIT-856:
-----------------------------
Resolution: Merged (was: Fixed)
Status: Closed (was: Merge Request)
> more documentation for utilities would be cool
> ----------------------------------------------
>
> Key: BIT-856
> URL: https://bro-tracker.atlassian.net/browse/BIT-856
> Project: Bro Issue Tracker
> Issue Type: New Feature
> Components: Bro, bro-aux, BroControl, trace-summary
> Affects Versions: git/master
> Reporter: Vern Paxson
> Assignee: Daniel Thayer
> Fix For: 2.4
>
> Attachments: bro.8, broctl.8, bro-cut.1, trace-summary.1
>
>
> Utilities like bro-cut only supply \--help documentation, as far as I can tell. Man pages would be handy. (In particular, I was looking for some sort of statement of exactly to what degree bro-cut can munch on the concatenation of multiple log files that have different column layouts.)
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-014#64007)
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ------------------------------------ ----------- ------------- ---------- ------------- ---------- ----------------------------------------------
BIT-856 [1] Bro,bro-aux,BroControl,trace-summary Vern Paxson Daniel Thayer 2014-12-05 2.4 Normal more documentation for utilities would be cool
[1] BIT-856 https://bro-tracker.atlassian.net/browse/BIT-856
Daniel Thayer created BIT-1297:
----------------------------------
Summary: trace-summary needs tests
Key: BIT-1297
URL: https://bro-tracker.atlassian.net/browse/BIT-1297
Project: Bro Issue Tracker
Issue Type: Problem
Components: trace-summary
Reporter: Daniel Thayer
Fix For: 2.4
There are no tests in the trace-summary repo.
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-014#64007)
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ------------------------------------ ----------- ------------- ---------- ------------- ---------- ----------------------------------------------
BIT-856 [1] Bro,bro-aux,BroControl,trace-summary Vern Paxson Daniel Thayer 2014-12-05 2.4 Normal more documentation for utilities would be cool
[1] BIT-856 https://bro-tracker.atlassian.net/browse/BIT-856
Open Merge Requests
===================
ID Component Reporter Assignee Updated For Version Priority Summary
----------- ------------------------------------ ----------- ------------- ---------- ------------- ---------- ----------------------------------------------
BIT-856 [1] Bro,bro-aux,BroControl,trace-summary Vern Paxson Daniel Thayer 2014-12-05 2.4 Normal more documentation for utilities would be cool
[1] BIT-856 https://bro-tracker.atlassian.net/browse/BIT-856
[ https://bro-tracker.atlassian.net/browse/BIT-856?page=com.atlassian.jira.pl… ]
Daniel Thayer updated BIT-856:
------------------------------
Status: Merge Request (was: Open)
> more documentation for utilities would be cool
> ----------------------------------------------
>
> Key: BIT-856
> URL: https://bro-tracker.atlassian.net/browse/BIT-856
> Project: Bro Issue Tracker
> Issue Type: New Feature
> Components: Bro, bro-aux, BroControl, trace-summary
> Affects Versions: git/master
> Reporter: Vern Paxson
> Assignee: Daniel Thayer
> Fix For: 2.4
>
> Attachments: bro.8, broctl.8, bro-cut.1, trace-summary.1
>
>
> Utilities like bro-cut only supply \--help documentation, as far as I can tell. Man pages would be handy. (In particular, I was looking for some sort of statement of exactly to what degree bro-cut can munch on the concatenation of multiple log files that have different column layouts.)
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-012#64007)
[ https://bro-tracker.atlassian.net/browse/BIT-856?page=com.atlassian.jira.pl… ]
Daniel Thayer commented on BIT-856:
-----------------------------------
These issues have now been addressed.
> more documentation for utilities would be cool
> ----------------------------------------------
>
> Key: BIT-856
> URL: https://bro-tracker.atlassian.net/browse/BIT-856
> Project: Bro Issue Tracker
> Issue Type: New Feature
> Components: Bro, bro-aux, BroControl, trace-summary
> Affects Versions: git/master
> Reporter: Vern Paxson
> Assignee: Daniel Thayer
> Fix For: 2.4
>
> Attachments: bro.8, broctl.8, bro-cut.1, trace-summary.1
>
>
> Utilities like bro-cut only supply \--help documentation, as far as I can tell. Man pages would be handy. (In particular, I was looking for some sort of statement of exactly to what degree bro-cut can munch on the concatenation of multiple log files that have different column layouts.)
--
This message was sent by Atlassian JIRA
(v6.4-OD-11-012#64007)