Jon Siwek created BIT-1098:
------------------------------
Summary: topic/jsiwek/broxygen
Key: BIT-1098
URL: https://bro-tracker.atlassian.net/browse/BIT-1098
Project: Bro Issue Tracker
Issue Type: Improvement
Components: Bro, Broccoli
Affects Versions: git/master
Reporter: Jon Siwek
Fix For: 2.3
This branch is in the bro and broccoli repos and improves the automated script-reference documentation generation process, broxygen.
This should address issues in BIT-701 and BIT-751, let me know if there's anything not covered that's still relevant.
Highlights:
- Remove {{--doc-scripts}} and {{-Z}} options to toggle documentation mode -- the parser is now always instrumented to gather documentation from comments of the form "##", "##!", or "##<".
- Raw comments are available at runtime through several BIF functions: {{get_*_comments}};
- Add {{--broxygen}} and {{-X}} options to toggle generating reST-format documentation output, driven by a config file argument.
- Add a "broxygen" Sphinx extension domain, allowing certain pieces of documentation to be generated on-the-fly via invoking a Bro process. Re-organized/cleaned up the Sphinx source tree in {{doc/}} to use this in some places.
--
This message was sent by Atlassian JIRA
(v6.2-OD-03#6206)
[ https://bro-tracker.atlassian.net/browse/BIT-1098?page=com.atlassian.jira.p… ]
Jon Siwek updated BIT-1098:
---------------------------
Status: Merge Request (was: Open)
> topic/jsiwek/broxygen
> ---------------------
>
> Key: BIT-1098
> URL: https://bro-tracker.atlassian.net/browse/BIT-1098
> Project: Bro Issue Tracker
> Issue Type: Improvement
> Components: Bro, Broccoli
> Affects Versions: git/master
> Reporter: Jon Siwek
> Fix For: 2.3
>
>
> This branch is in the bro and broccoli repos and improves the automated script-reference documentation generation process, broxygen.
> This should address issues in BIT-701 and BIT-751, let me know if there's anything not covered that's still relevant.
> Highlights:
> - Remove {{--doc-scripts}} and {{-Z}} options to toggle documentation mode -- the parser is now always instrumented to gather documentation from comments of the form "##", "##!", or "##<".
> - Raw comments are available at runtime through several BIF functions: {{get_*_comments}};
> - Add {{--broxygen}} and {{-X}} options to toggle generating reST-format documentation output, driven by a config file argument.
> - Add a "broxygen" Sphinx extension domain, allowing certain pieces of documentation to be generated on-the-fly via invoking a Bro process. Re-organized/cleaned up the Sphinx source tree in {{doc/}} to use this in some places.
--
This message was sent by Atlassian JIRA
(v6.2-OD-03#6206)
Robin Sommer created BIT-1097:
---------------------------------
Summary: Unexpected string indexing behavior
Key: BIT-1097
URL: https://bro-tracker.atlassian.net/browse/BIT-1097
Project: Bro Issue Tracker
Issue Type: Problem
Components: Bro
Affects Versions: 2.2
Reporter: Robin Sommer
Playing with string indexing/slicing, I'm seeing some (I think) non-intuitive behavior:
{code}
global s = "012345";
print "A";
print s[1:-1];
print s[1:-2];
print s[1:-3];
print s[1:-4];
print s[1:-5];
print s[1:-6];
print s[1:-7];
print s[1:-8];
print s[1:-9];
print "";
print "B";
print s[-1:-1];
print s[-1:-2];
print s[-1:-3];
print s[-1:-4];
{code}
This prints:
{code}
A
12345
1234
123
12
1
12345
12345
12345
B
5
5
5
{code}
I would instead have expected:
(1) A to print empty lines for all cases with the 2nd index <= -6?
(2) B to print empty lines for all cases with the 2nd index <= -2?
So, is this intentional?
--
This message was sent by Atlassian JIRA
(v6.2-OD-03#6206)
Hey All,
Looking at the diff between the output of the two commands I was
slightly surprised.
bro -e 'event bro_script_loaded(script: string, levels: count) { print
script; }'
bro -be 'event bro_script_loaded(script: string, levels: count) {
print script; }'
I'm curious if Bro in bare mode is ever used for anything. I'm not
surprised to see bare mode include bifs. Is there a design decision
why bare mode includes things like the input and logging framework but
not the protocol directories that make use of them (e.g.
bro/base/protocols/conn) ?
-AK
[ https://bro-tracker.atlassian.net/browse/BIT-1096?page=com.atlassian.jira.p… ]
Seth Hall updated BIT-1096:
---------------------------
Resolution: Won't Fix
Status: Closed (was: Open)
Unfortunately there isn't a better way to check the version at this time.
> Should check version of libmagic not version of file
> ----------------------------------------------------
>
> Key: BIT-1096
> URL: https://bro-tracker.atlassian.net/browse/BIT-1096
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: Bro
> Affects Versions: 2.2
> Environment: Mac OS X 10.6.8; libmagic and other dependencies installed using MacPorts
> Reporter: Ryan Schmidt
>
> As far as I can tell, bro requires the libmagic library, but not the file program. However bro's configuration script appears not to be checking the version of the libmagic library, but the version of the file program. This is a problem in distributions like MacPorts where the libmagic library and the file program are in separate packages; installing the libmagic package does not mean you will automatically get the corresponding version of the file program.
> This causes a build failure on Mac OS X 10.6 Snow Leopard for example which ships with /usr/bin/file version 5.03. Even though libmagic 5.15 is installed from MacPorts, bro fails to configure, thinking it's too old. The MacPorts project's bug report for that is https://trac.macports.org/ticket/41457
> Could you change bro's configuration script to check the version of libmagic instead? You can check MAGIC_VERSION in magic.h.
--
This message was sent by Atlassian JIRA
(v6.2-OD-03#6206)