#846: Tests Failures
---------------------+------------------------
Reporter: robin | Owner:
Type: Problem | Status: new
Priority: High | Milestone: Bro2.1
Component: Bro | Version: git/master
Keywords: |
---------------------+------------------------
The is collected from mails:
{{{
core.checksums … failed [Gilbert, Matthias; non-determinisitc]
bifs.system [Gilbert; should should be fixed by now, please double-check]
istate.bro-ipv6-socket … failed [Fails if IPv6 connectivity not available
(fw in this case); can we test for that somehow? Otherwise, fine to leave
as it is for now.)
istate.broccoli-ipv6-socket … failed [Same]
scripts.base.protocols.smtp.basic [Matthias; with clang]
scripts.base.frameworks.logging.rotate-custom [Matthias; with clang]
core.dns-init [Adam; when using dnscrypt from OpenDNS]
}}}
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/846>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
So, the documentation right above it should probably be changed also.
Also, while we're at it, "seperate," "signle," and "rised" might as well
be fixed.
--Vlad
On 7/27/12 12:14 AM, "Bernhard Amann" <bernhard(a)ICSI.Berkeley.EDU> wrote:
diff --git a/scripts/base/frameworks/input/main.bro
b/scripts/base/frameworks/input/main.bro
index c31f92d..7f01540 100644
--- a/scripts/base/frameworks/input/main.bro
+++ b/scripts/base/frameworks/input/main.bro
@@ -84,7 +84,7 @@ export {
## If want_record if false (default), the event receives each value in
fields as a seperate argument.
## If it is set to true, the event receives all fields in a signle
record value.
- want_record: bool &default=F;
+ want_record: bool &default=T;
## The event that is rised each time a new line is received from the
reader.
## The event will receive an Input::Event enum as the first element, and
the fields as the following arguments.
#858: Logging framework stops completely when DoInit returns false
---------------------+------------------------
Reporter: amannb | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version: git/master
Keywords: |
---------------------+------------------------
This has to be introduced quite recently - I tried to find the reason for
the bug, but I am just too blind at the Moment.
When one of the log writers returns from DoInit with false the whole
logging framework just seems to stop - no output is done anymore to any
file.
To reproduce - change the return code of DoInit in None.cc to false and
execute the attached Bro script.
Logs will be written until the first http request is encountered. Starting
from that moment, all activity stops and no more log messages are output
to any file (including reporter/debug.log).
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/858>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
On Mon, Jul 23, 2012 at 17:01 -0700, I wrote:
> Merge branch 'topic/robin/master-test'
This has the recent threading changes, plus all other pending merge
requests.
Please test, I hope it doesn't break anything ..
Problems remaining:
- Occasional tests failures reporting a bad file descriptor on Mac
OS. Reason still unclear.
- #start timestamps can be 1969-... when network time is not yet
set.
- tuning/logs-to-elasticsearch.bro not loaded by test-all-policy
because it triggers lock-ups.
Robin
--
Robin Sommer * Phone +1 (510) 722-6541 * robin(a)icir.org
ICSI/LBNL * Fax +1 (510) 666-2956 * www.icir.org
Gave master a try today. Hardly saw any clang warnings. Did get the following on tests (after turning off DNSCrypt).
[ 25%] bifs.to_double_from_string ... failed
1 of 304 tests failed, 21 skipped
make[2]: *** [btest-verbose] Error 1
Coverage for 'btest' dir:
1051/1711 (61.4%) Bro script statements covered.
Coverage for 'external' dir:
Complete test suite code coverage:
1051/1711 (61.4%) Bro script statements covered.
Output of diag.log:
bifs.to_double_from_string ... failed
% 'btest-diff error' failed unexpectedly (exit code 1)
% cat .diag
== File ===============================
error in /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 7 and /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 15: bad conversion to count (to_double(d) and NotADouble)
error in /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 7 and /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 16: bad conversion to count (to_double(d) and )
== Diff ===============================
--- /tmp/test-diff.33926.error.baseline.tmp 2012-07-25 18:52:04.000000000 +0000
+++ /tmp/test-diff.33926.error.tmp 2012-07-25 18:52:04.000000000 +0000
@@ -1,2 +1,2 @@
-error in /da/home/robin/bro/master/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 7 and /da/home/robin/bro/master/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 15: bad conversion to count (to_double(d) and NotADouble)
-error in /da/home/robin/bro/master/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 7 and /da/home/robin/bro/master/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 16: bad conversion to count (to_double(d) and )
+error in /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 7 and /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 15: bad conversion to count (to_double(d) and NotADouble)
+error in /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 7 and /Users/slagell/Downloads/bro/testing/btest/.tmp/bifs.to_double_from_string/to_double_from_string.bro, line 16: bad conversion to count (to_double(d) and )
=======================================
% cat .stderr
core.mobile-ipv6-home-addr ... not available, skipped
core.mobile-ipv6-routing ... not available, skipped
core.mobility-checksums ... not available, skipped
core.mobility_msg ... not available, skipped
core.leaks.ayiya ... not available, skipped
core.leaks.basic-cluster ... not available, skipped
core.leaks.dataseries-rotate ... not available, skipped
core.leaks.dataseries ... not available, skipped
core.leaks.dns ... not available, skipped
core.leaks.incr-vec-expr ... not available, skipped
core.leaks.ip-in-ip ... not available, skipped
core.leaks.ipv6_ext_headers ... not available, skipped
core.leaks.teredo ... not available, skipped
core.leaks.remote ... not available, skipped
core.leaks.vector-val-bifs ... not available, skipped
core.leaks.test-all ... not available, skipped
scripts.base.frameworks.logging.dataseries.options ... not available, skipped
scripts.base.frameworks.logging.dataseries.rotate ... not available, skipped
scripts.base.frameworks.logging.dataseries.test-logging ... not available, skipped
scripts.base.frameworks.logging.dataseries.time-as-int ... not available, skipped
scripts.base.frameworks.logging.dataseries.wikipedia ... not available, skipped
slagell@prometheus: bro $
------
Adam J. Slagell, CISO, CISSP
Chief Information Security Officer
National Center for Supercomputing Applications
University of Illinois at Urbana-Champaign
www.slagell.info
217.244.8965
"Under the Illinois Freedom of Information Act (FOIA), any written communication to or from University employees regarding University business is a public record and may be subject to public disclosure."
#859: to_double bif
------------------------+-----------------------------
Reporter: scampbell | Type: Feature Request
Status: new | Priority: Normal
Milestone: Bro2.1 | Component: Bro
Version: git/master | Keywords: bif
------------------------+-----------------------------
It would be quite useful to include a to_double bif as the new input
framework makes this sort of thing much more common when digesting logs.
sample code:
## Converts a :bro:type:`string` to a :bro:type:`double`.
##
## str: The :bro:type:`string` to convert.
##
## Returns: The :bro:type:`string` *str* as double, or 0 if *str* has
## an invalid format.
##
function to_double%(str: string%): count
%{
const char* s = str->CheckString();
char* end_s;
double d = (double) strtod(s, &end_s);
if ( s[0] == '\0' || end_s[0] != '\0' )
{
builtin_error("bad conversion to count", @ARG@[0]);
d = 0;
}
return new Val(d, TYPE_DOUBLE);
%}
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/859>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
#855: unhelpful bro-cut error message for bad field
---------------------+------------------------
Reporter: vern | Owner:
Type: Problem | Status: new
Priority: Normal | Milestone:
Component: Bro | Version: git/master
Keywords: |
---------------------+------------------------
If I run "{{{bro-cut foo}}}" on a log file that doesn't have a field
named {{{foo}}}, the message it generates is:
{{{
bro-cut error: unknown field f[i]
}}}
Looks like a level of de-referencing got left off.
--
Ticket URL: <http://tracker.bro-ids.org/bro/ticket/855>
Bro Tracker <http://tracker.bro-ids.org/bro>
Bro Issue Tracker
HI,
So far my DNP3 analzyer works OK on well-formatted DNP3 dump, even the
packets are not in the right order.
However, when I test it again some fuzzied DNP3 packets, this error
sometimes happens. The weird thing is that, I run the same dump several
times, sometimes, it can finish the work with weird.log, and sometimes Bro
throws out this error.
terminate called after throwing an instance of 'std::length_error'
what(): vector::reserve
Aborted
Any idea?
--
Hui Lin
PhD Candidate, Research Assistant
Electrical and Computer Engineering Department
University of Illinois at Urbana-Champaign